Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sample script for tests for multimodel statistics preprocessor function #4

Merged
merged 11 commits into from
Nov 10, 2020
Merged

Improve sample script for tests for multimodel statistics preprocessor function #4

merged 11 commits into from
Nov 10, 2020

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 5, 2020 •
edited
Loading

  • Add ocean datasets This needs better support for slicing grids with 2D lat/lon coordinates in iris first
  • Use directory structure
  • Improve horizontal slicing
  • Clean up
  • Run the script, download data and upload to GitHub

@bouweandela bouweandela mentioned this pull request Nov 5, 2020
Closed
11 tasks
@bouweandela
Copy link
Member Author

Doing acceptable horizontal slicing of ocean data is more difficult than expected. Will use just variable ta for now.

@bouweandela bouweandela marked this pull request as ready for review November 9, 2020 20:32
@bouweandela bouweandela mentioned this pull request Nov 9, 2020
Merged
stefsmeets
stefsmeets approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just tested it on my machine and it runs without issues.
My only comment would be to move sample_data.py to the root directory and name it something more descriptive like download_sample_data.py

@stefsmeets stefsmeets merged commit d5cee89 into master Nov 10, 2020
@stefsmeets stefsmeets deleted the sample-script branch November 10, 2020 10:05
@stefsmeets stefsmeets linked an issue Nov 17, 2020 that may be closed by this pull request
Populate repository with data #1
Open
3 tasks
@stefsmeets stefsmeets mentioned this pull request Nov 17, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate repository with data
2 participants
@bouweandela @stefsmeets