Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCPPize dme_adjust #211

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

CCPPize dme_adjust #211

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15bc496
Preliminary dme work and create conservation_adjust directory
cacraigucar Feb 14, 2025
0b7a63c
Updates for CAM-SIMA
cacraigucar Feb 19, 2025
9837e47
Merge remote-tracking branch 'upstream/development' into atmos_dme_adj
cacraigucar Feb 20, 2025
ec5106b
Update dme_adjust in SDFs
cacraigucar Feb 20, 2025
4b58b30
Fixes to run in CAM-SIMA
cacraigucar Feb 24, 2025
ef4c35f
Merge remote-tracking branch 'upstream/development' into atmos_dme_adj
cacraigucar Feb 26, 2025
0cc62ba
Add comment regarding dme_adjust in kessler and tj2016 SDFs
cacraigucar Feb 27, 2025
b5925a8
Fix comments
cacraigucar Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions suites/suite_kessler.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<!-- Update cp/cv for energy computation based in updated water variables -->
<scheme>thermo_water_update</scheme>

<-- COMMENTED OUT until qini/liqini/iceini have initialization routines -->
<!-- <scheme>dme_adjust</scheme> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume that this is not enabled because CAM-SIMA cannot run dme_adjust standalone due to qini/liqini/iceini not being set, could you confirm? It would be good to make a note of the reason why this will remain disabled, after this scheme is available, to signal that this is intentional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cacraigucar thanks for adding the comment, I think you may have missed a ! in the xml comment syntax (should be <!-- starting instead of <--)


<!-- MPAS and SE specific scaling of temperature for enforcing energy consistency:
Expand Down
2 changes: 1 addition & 1 deletion suites/suite_tj2016.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
<scheme>qneg</scheme>

<!-- Update cp/cv for energy computation based in updated water variables -->
<scheme>thermo_water_update</scheme>

<-- COMMENTED OUT until qini/liqini/iceini have initialization routines -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue regarding the comment syntax here (should be <!-- instead of <--)

<!-- <scheme>dme_adjust</scheme> -->

<!-- MPAS and SE specific scaling of temperature for enforcing energy consistency:
Expand Down