Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rayleigh Friction CCPP #200

Open
wants to merge 30 commits into
base: development
Choose a base branch
from
Open

Conversation

Katetc
Copy link
Collaborator

@Katetc Katetc commented Feb 4, 2025

I think I need to merge up, but I did all of the steps! This adds CCPP support for the Rayleigh Friction parameterization.

Fixes #35
Fixes #119

cacraigucar and others added 23 commits August 15, 2024 12:48
Pull ZM 0.5 timestep removal into main
Replace original, locally-developed license with Apache 2.0 license.
Bring in development ESCOMP#108 (TUV-x) ESCOMP#112 (tropopause_find) to main
Bring in new directory structure from development
Upgrading to atmos_phys0_06_000
Tag name (The PR title should also include the tag name):
`atmos_phys0_07_000`
Originator(s): @jimmielin

List all `development` PR URLs included in this PR and a short
description of each:
* ESCOMP#141 by @mattldawson @boulderdaze 
* ESCOMP#147 by @peverwhee 
* ESCOMP#144 by @mwaxmonsky 
* ESCOMP#151 by @mattldawson 
* ESCOMP#145 by @jimmielin 

List all test failures: N/A
Tag name (The PR title should also include the tag name):
`atmos_phys0_07_001`
Originator(s): @jimmielin

List all `development` PR URLs included in this PR and a short
description of each:
* Update extraterrestrial flux in TUV-x prior to calculating rate constants ESCOMP#152 by @boulderdaze
* Simplify deallocation of multiple objects associated with the TUV-x ESCOMP#156 by @boulderdaze
* Fill in errmsg, errflg in check_energy schemes ESCOMP#160 by @jimmielin
* Validates the MUSICA meta data against the CCPP standard names ESCOMP#162 by @boulderdaze
* Add constituent tendency updater ESCOMP#111 by @peverwhee
* Add cloud optical calculations for use in TUV-x ESCOMP#167 by @mattldawson
* Add initialize_constituents scheme ESCOMP#149 by @peverwhee
* Add diagnostics to TJ2016 test schemes ESCOMP#170 by @peverwhee
* update "radians" to "rad" ESCOMP#173 by @peverwhee
* Solar zenith angle and Earth-Sun distance ESCOMP#171 by @mattldawson
* Update standard names for tropopause_find ESCOMP#140 by @jimmielin
* Update surface albedo units ESCOMP#181 by @mattldawson
* don't set water species property for species that air_composition handles ESCOMP#185 by @peverwhee

List all test failures: N/A
@Katetc Katetc self-assigned this Feb 4, 2025
@Katetc Katetc requested review from peverwhee and nusbaume February 4, 2025 20:49
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small things. Thanks so much @Katetc !

@Katetc Katetc requested a review from peverwhee February 20, 2025 20:54
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help on this physics scheme @Katetc! I just had a few (hopefully minor) requests, mostly related to comments and standard names.

@Katetc Katetc requested a review from nusbaume March 1, 2025 00:27
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Katetc !

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great now. Thanks again @Katetc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants