Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_4_056: Nitrogen deposition fluxes #1216

Merged
merged 16 commits into from
Jan 17, 2025
Merged

cam6_4_056: Nitrogen deposition fluxes #1216

merged 16 commits into from
Jan 17, 2025

Conversation

fvitt
Copy link

@fvitt fvitt commented Dec 30, 2024

Addresses #1196

fvitt added 8 commits December 11, 2024 13:56
@fvitt
more sane way to control nitrogen deposition to surface models
fa69b87 
	modified:   bld/build-namelist
	modified:   bld/namelist_files/namelist_defaults_cam.xml
	modified:   bld/namelist_files/namelist_definition.xml
	modified:   bld/namelist_files/use_cases/1850_cam_lt.xml
	modified:   bld/namelist_files/use_cases/1850_cam_mt.xml
	modified:   bld/namelist_files/use_cases/hist_cam_lt.xml
	modified:   bld/namelist_files/use_cases/hist_cam_mt.xml
	modified:   cime_config/buildnml
	modified:   cime_config/config_component.xml
	modified:   src/chemistry/mozart/chemistry.F90
	modified:   src/chemistry/mozart/mo_chm_diags.F90
	modified:   src/chemistry/pp_none/chemistry.F90
	modified:   src/control/camsrfexch.F90
	modified:   src/control/runtime_opts.F90
	modified:   src/cpl/nuopc/atm_import_export.F90
	modified:   src/cpl/nuopc/atm_stream_ndep.F90
	modified:   src/physics/cam/cam_diagnostics.F90
	modified:   src/utils/srf_field_check.F90
@fvitt
fix some issues in derecho regression tests
b70cfea 
	modified:   bld/build-namelist
	modified:   bld/namelist_files/namelist_defaults_cam.xml
	modified:   bld/namelist_files/namelist_definition.xml
	modified:   bld/namelist_files/use_cases/2010_cam6.xml
	modified:   bld/namelist_files/use_cases/sd_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_sc_1850_cam6.xml
	modified:   src/chemistry/geoschem/chemistry.F90
	modified:   src/chemistry/pp_terminator/chemistry.F90
	modified:   src/control/camsrfexch.F90
@fvitt
ChangeLog start; code clean up; add ndep diags to reg test
24e012d 
	modified:   cime_config/testdefs/testmods_dirs/cam/outfrq9s_Leung_dust/user_nl_cam
	modified:   doc/ChangeLog
	modified:   src/utils/srf_field_check.F90
@fvitt
fix restart problem with nitrogen flux history fields
82a3c9c 
	modified:   src/physics/cam/cam_diagnostics.F90
	modified:   src/physics/cam/physpkg.F90
@fvitt
add addfld calls to cam7 phys
bba4e59 
	modified:   src/physics/cam7/physpkg.F90
@fvitt
units correction in diagnostics
9066aee 
	modified:   src/cpl/nuopc/atm_import_export.F90
	modified:   src/cpl/nuopc/atm_stream_ndep.F90
	modified:   src/physics/cam/cam_diagnostics.F90
@fvitt
set fldptr_ndep to zero for no flux cases
97fd801 
	modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
namelist fixes
31796b2 
	modified:   bld/namelist_files/namelist_defaults_cam.xml
	modified:   bld/namelist_files/use_cases/1850_cam6.xml
	modified:   bld/namelist_files/use_cases/hist_cam6.xml
@fvitt fvitt self-assigned this Dec 30, 2024
@brian-eaton brian-eaton self-requested a review December 31, 2024 15:41
brian-eaton
brian-eaton requested changes Jan 6, 2025
View reviewed changes
fvitt added 2 commits January 8, 2025 14:54
@fvitt
use sim_year to determine stream_ndep settings; remove deprecated nde…
9848f15 
…p_list

	modified:   bld/build-namelist
	modified:   bld/namelist_files/namelist_defaults_cam.xml
	modified:   bld/namelist_files/namelist_definition.xml
	modified:   bld/namelist_files/use_cases/1850_cam6.xml
	modified:   bld/namelist_files/use_cases/1850_cam_lt.xml
	modified:   bld/namelist_files/use_cases/1850_cam_mt.xml
	modified:   bld/namelist_files/use_cases/2000_geoschem.xml
	modified:   bld/namelist_files/use_cases/2000_trop_strat_vbs_cam6.xml
	modified:   bld/namelist_files/use_cases/2010_cam6.xml
	modified:   bld/namelist_files/use_cases/2010_geoschem.xml
	modified:   bld/namelist_files/use_cases/2010_trop_strat_vbs_cam6.xml
	modified:   bld/namelist_files/use_cases/hist_cam6.xml
	modified:   bld/namelist_files/use_cases/hist_cam_lt.xml
	modified:   bld/namelist_files/use_cases/hist_cam_mt.xml
	modified:   bld/namelist_files/use_cases/hist_geoschem.xml
	modified:   bld/namelist_files/use_cases/hist_geoschem_nudged.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_nudged_cam6.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_vbsext_cam6.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_vbsfire_cam6.xml
	modified:   bld/namelist_files/use_cases/sd_cam6.xml
	modified:   bld/namelist_files/use_cases/sd_trop_strat2_cam6.xml
	modified:   bld/namelist_files/use_cases/sd_trop_strat_vbs_cam6.xml
	modified:   bld/namelist_files/use_cases/sd_waccm_tsmlt_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_ma_1850_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_ma_hist_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_sc_1850_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_1850_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_2000_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_2010_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_tsmlt_hist_cam6.xml
@fvitt
update ChangeLog
e106d4f
brian-eaton
brian-eaton reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@brian-eaton brian-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of sim_year in namelist_definition.xml needs to have 2010 and 1850-2015 added to the list of valid values.

I wasn't sure whether the sim_year attribute needed to be added to any of the use case files that don't currently set it. It depends on whether the use case is for a configuration that prognoses the ndep fluxes or not. I don't know how to figure that out without running the model.

@fvitt
add sim_year valid values of 2010 and 1850-2015
b30e948 
	modified:   bld/namelist_files/namelist_definition.xml
@cacraigucar cacraigucar self-requested a review January 10, 2025 18:13
cacraigucar
cacraigucar requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment requests

@fvitt
Add sim_year to geoschem use case files; ChangeLog updates
450312b 
	modified:   bld/build-namelist
	modified:   bld/namelist_files/use_cases/2010_geoschem.xml
	modified:   bld/namelist_files/use_cases/hist_geoschem.xml
	modified:   bld/namelist_files/use_cases/hist_geoschem_nudged.xml
	modified:   doc/ChangeLog
@cacraigucar cacraigucar changed the title Nitrogen deposition fluxes cam6_4_056: Nitrogen deposition fluxes Jan 15, 2025
@fvitt fvitt merged commit ea101b3 into ESCOMP:cam_development Jan 17, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 13, 2025
@fvitt
ESCOMP tag: cam6_4_056
f39db4a 
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes

cam6_4_056: Nitrogen deposition fluxes

ESCOMP commit: ea101b3
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 19, 2025
@fvitt
ESCOMP tag: cam6_4_056
d7635df 
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes

cam6_4_056: Nitrogen deposition fluxes

ESCOMP commit: ea101b3
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 23, 2025
@fvitt
ESCOMP tag: cam6_4_056
c184f2b 
Merge pull request ESCOMP#1216 from fvitt/nitro_dep_fluxes

cam6_4_056: Nitrogen deposition fluxes

ESCOMP commit: ea101b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-eaton brian-eaton brian-eaton approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

Assignees

@fvitt fvitt

Labels
None yet
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvitt @brian-eaton @cacraigucar