Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_070: Pertlim fix for MPAS #1114

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

patcal
Copy link
Collaborator

@patcal patcal commented Jul 29, 2024

Closes #1109

Copy link
Collaborator

@jtruesdal jtruesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mods are fine. @cacraigucar I was surprised that there aren't pertlim regression tests since ensembles are an important part of climate analysis. I'll bring that up in our SE meeting and see if we need an issue to provide testing for all supported dycores. Since we don't have testing currently in place please run your own test to make sure that the pertlim namelist addition is working correctly and document this in your Changelog.

@cacraigucar
Copy link
Collaborator

@patcal - Could you please provide a test that you ran with this new pertlim that we can use as a basis of a CAM regression test?

@patcal
Copy link
Collaborator Author

patcal commented Aug 13, 2024 via email

@cacraigucar
Copy link
Collaborator

@patcal - Have you made any progress on creating a regression test? This PR is stalled until we get one made

@cacraigucar cacraigucar removed the chill label Aug 23, 2024
@nusbaume
Copy link
Collaborator

nusbaume commented Feb 4, 2025

@cacraigucar I have added the MPAS pertlim regression test that @patcal developed, so I think this PR is ready to be added to the CAM PR queue. Thanks!

@cacraigucar cacraigucar changed the title Pertlim fix for MPAS cam6_4_070: Pertlim fix for MPAS Feb 20, 2025
@nusbaume nusbaume merged commit e8de158 into ESCOMP:cam_development Feb 21, 2025
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Feb 23, 2025
Merge pull request ESCOMP#1114 from patcal/maps_pertlim_fix

cam6_4_070: Pertlim fix for MPAS

ESCOMP commit: e8de158
cacraigucar added a commit to cacraigucar/CAM that referenced this pull request Feb 27, 2025
Merge pull request ESCOMP#1114 from patcal/maps_pertlim_fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

4 participants