cam6_4_007: CCPP-ized TJ2016

[mwaxmonsky]

Tag name: cam6_4_007
Originator(s): Michael Waxmonsky
Date: 7/8/2024
One-line Summary: cam6_4_007: CCPP-ized TJ2016
Github PR URL: #1070

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

• Exchanges TJ2016 source from cam/physics/simple to atmospheric_physics
  submodule (Implementation of CCPP-ized TJ2016 atmospheric_physics#92)

Describe any changes made to build system:

• Adds src/atmos_phys/tj2016 to list of folders to search for compiling in
  /bld/atm/obj/Filepath used during ./preview_namelists

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: cacraigucar, nusbaume

List all files eliminated:

$ git diff --name-status cam_development..tj2016 | grep ^D
D src/physics/simple/tj2016.F90

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:

$ git diff --name-status cam_development..tj2016 | grep ^M

M .gitmodules

• Updating atmospheric_physics to tag atmos_phys0_03_000

M bld/configure

• See comment to change in build system

M src/physics/simple/tj2016_cam.F90

• Updated API into CCPP-ized TJ2016 precip and sfc_plb_hs run functions
  (See Implementation of CCPP-ized TJ2016 atmospheric_physics#92 for API change desciription).

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:

ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s (Overall: FAIL) details:
  FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s COMPARE_base_rest
SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s
(Overall: FAIL) details:
  FAIL SMS_D_Ln9_P1280x1.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.FHIST.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD time=3
SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s (Overall: PEND) details:
  PEND SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s SHAREDLIB_BUILD
SMS_D_Ln9.T42_T42.FSCAM.derecho_intel.cam-outfrq9s (Overall: PEND) details:
  PEND SMS_D_Ln9.T42_T42.FSCAM.derecho_intel.cam-outfrq9s RUN RERUN

• Pre-existing failures

izumi/nag/aux_cam:

DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae (Overall: FAIL) details:
  FAIL DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae RUN time=12
  PEND DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae COMPARE_base_da

• Pre-existing failure

izumi/gnu/aux_cam: N/A

CAM tag used for the baseline comparison tests if different than previous
tag:

• cesm2_3_alpha17g for manually testing FTJ16 compset, previous baseline for aux_cam tests

Summarize any changes to answers, i.e.,

• what code configurations:
• what platforms/compilers:
• nature of change (roundoff; larger than roundoff but same climate; new climate): N/A

[cacraigucar]

After out discussed revisions - this looks great!

[nusbaume]

Looks good to me! Chatted with @mwaxmonsky offline about some nit-picky spacing stuff, but it shouldn't impact the results at all.