Merge pull request #11 from EOSLaoMao/feature/safe-transfer

use proxy transfer account to avoid RAM abuse

include/bankofstaked/bankofstaked.hpp

@@ -13,6 +13,7 @@ namespace bank
 {
 static const account_name code_account = N(bankofstaked);
 static const account_name ram_payer = N(bankofstaked);
+static const account_name safe_transfer_account = N(masktransfer);
 static const uint64_t SECONDS_PER_MIN = 60;
 static const uint64_t SECONDS_PER_DAY = 24 * 3600;
 static const uint64_t MAX_PAID_ORDERS = 5;

src/bankofstaked.cpp

@@ -422,11 +422,14 @@ class bankofstaked : contract
       if (order.is_free == FALSE)
       {
         auto plan = p.get(order.plan_id);
-        std:string memo = "bankofstaked income";
+
+        auto username = name{order.creditor};
+        std::string recipient_name = username.to_string();
+        std::string memo = recipient_name + " bankofstaked income";
         action act3 = action(
           permission_level{ code_account, N(bankperm) },
           N(eosio.token), N(transfer),
-          std::make_tuple(code_account, order.creditor, order.price, memo)
+          std::make_tuple(code_account, safe_transfer_account, order.price, memo)
         );
         out.actions.emplace_back(act3);
       }
@@ -522,16 +525,19 @@ class bankofstaked : contract
         order_id = i.id;
       });
 
-      // if plan is free, add a Freelock entry
       if(plan->is_free == TRUE)
       {
+        // if plan is free, add a Freelock entry
         add_freelock(beneficiary);
         // auto refund immediately
         //INLINE ACTION to auto refund
         creditor_table c(code_account, SCOPE_CREDITOR>>1);
         std::string free_memo = c.get(creditor).free_memo;
+        auto username = name{buyer};
+        std::string buyer_name = username.to_string();
+        std::string memo = buyer_name + " " + free_memo;
         INLINE_ACTION_SENDER(eosio::token, transfer)
-        (N(eosio.token), {{code_account, N(bankperm)}}, {code_account, buyer, plan->price, free_memo});
+        (N(eosio.token), {{code_account, N(bankperm)}}, {code_account, safe_transfer_account, plan->price, memo});
       }
 
       //deferred transaction to auto undelegate after expired

src/utils.cpp

@@ -11,6 +11,7 @@ namespace utils
     if (memo.length() > 0)
     {
       to = string_to_name(memo.c_str());
+      eosio_assert( is_account( to ), "to account does not exist");
     }
     return to;
   }