Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip 1641 fix subsample reads #245

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Pip 1641 fix subsample reads #245

merged 2 commits into from
Nov 12, 2021

Conversation

leepc12
Copy link
Contributor

@leepc12 leepc12 commented Nov 12, 2021

chip.subsample_reads was used for subsampling controls instead of chip.ctl_subsampled_reads

ottojolanki
ottojolanki approved these changes Nov 12, 2021
View reviewed changes
Copy link

@ottojolanki ottojolanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leepc12 leepc12 requested a review from ottojolanki November 12, 2021 23:34
@leepc12 leepc12 merged commit e0c687e into dev Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ottojolanki ottojolanki Awaiting requested review from ottojolanki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leepc12 @ottojolanki