Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip 1631 new conda builder #241

Merged
merged 17 commits into from
Oct 25, 2021
Merged

Pip 1631 new conda builder #241

merged 17 commits into from
Oct 25, 2021

Conversation

leepc12
Copy link
Contributor

@leepc12 leepc12 commented Oct 22, 2021

Compatibility for dockstore (Terra and DNAnexus)

  • Can define docker image in input JSON

Since all tasks have docker attribute in runtime, old caper(<2.0) will not work with Conda and Singularity.
It will ignore conda, singularity in runtime and try to run pipelines with docker even on HPCs.

Main changes in this PR:

  • To pass docker/singularity/conda to each WDL task.
  • Conda environment builder script.
  • DX workflow builder script.
    • -defaults defines input JSON, -extras defines workflow opts JSON. Removed -extras since we no longer need it to define default docker image for all tasks.
  • Documentation
  • Some changes in resource parameters (increased resource factors for gc_bias, spr)

@leepc12 leepc12 requested review from paul-sud and ottojolanki and removed request for paul-sud October 25, 2021 16:26
Copy link

@ottojolanki ottojolanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leepc12 leepc12 merged commit 241e405 into master Oct 25, 2021
@leepc12 leepc12 deleted the PIP-1631_new_conda_builder branch October 25, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants