moved search.py outside of module ./apprentice/app/main/search into .… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ll-O-ll
commented
Oct 31, 2020
ll-O-ll
commented
- Solved issue of importing from ./apprentice/app/main/search.
- Flask complains that it is a relative path
- Moved single file outside to path/to/search module to keep things simple
- In the future, if multiple files are needed under a single directory (module) maybe look into how Flask Blueprints work
…/apprentice/app/main
- Fetch elasticsearch connection from the current context-global at the time of search - Previously we relied on whatever the value was at the time of import - Issue with this is that the app may not be initialized at the time (e.g. flask shell), or we may be using another instance of the app (e.g. behind a load balancer in the future)
- Docstring comment for attribution was showing up as the test name, so changed those to line comments - Elasticsearch was printing shard health warnings (not errors) due to the tests running right as it woke up, but adding a small wait fixes that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.