Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ilamb tasks #574

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Updates for ilamb tasks #574

merged 2 commits into from
Apr 12, 2024

Conversation

chengzhuzhang
Copy link
Collaborator

In this PR:
A bug is fixed in testing a piControl run when the start and end year needs to be padded with 0.
Add supports to grids other than 180x360_aave for ilamb tasks.

@chengzhuzhang chengzhuzhang requested a review from forsyth2 April 11, 2024 23:10
@chengzhuzhang
Copy link
Collaborator Author

@forsyth2 this PR is ready for review. I tested using a v3 piControl run with 2 cases, first one remaping the v3 ELM data to 180x360_aave. The other with native regular lat-lon v3 ELM output. Both runs were successful. Except i still run into the ilamb issue, which was filed with ilamb developers.rubisco-sfa/ILAMB#86

I also update the ilamb DATA at lcrc input server, for a recent fix (rubisco-sfa/ILAMB#89), which should remember to propagate to other machines.

Copy link
Collaborator

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From visual inspection of the code, and since you already tested on a couple cases, this looks good to me. I can more thoroughly test as part of the zppy RC testing tomorrow. So, I think this is good to merge.

I'm assuming it's ok to proceed with making a zppy RC despite the ILAMB issue (rubisco-sfa/ILAMB#86)? (Users will just have to be aware of the bug in ILAMB).

I also update the ilamb DATA at lcrc input server, for a recent fix (rubisco-sfa/ILAMB#89), which should remember to propagate to other machines.

Is that something that needs to be done as part of the RC testing/release process then? What is involved with that?

zppy/templates/default.ini Outdated Show resolved Hide resolved
@chengzhuzhang
Copy link
Collaborator Author

chengzhuzhang commented Apr 12, 2024

From visual inspection of the code, and since you already tested on a couple cases, this looks good to me. I can more thoroughly test as part of the zppy RC testing tomorrow. So, I think this is good to merge.

Sounds good!

I'm assuming it's ok to proceed with making a zppy RC despite the ILAMB issue (rubisco-sfa/ILAMB#86)? (Users will just have to be aware of the bug in ILAMB).

Yes, the ILAMB issue is most likely out of our hands.

I also update the ilamb DATA at lcrc input server, for a recent fix (rubisco-sfa/ILAMB#89), which should remember to propagate to other machines.

Is that something that needs to be done as part of the RC testing/release process then? What is involved with that?

Yes, before testing, it would be nice to sync the data to different machines.

@forsyth2 forsyth2 merged commit adc64b7 into main Apr 12, 2024
4 checks passed
@forsyth2
Copy link
Collaborator

@chengzhuzhang Thanks, I just merged this PR

Yes, before testing, it would be nice to sync the data to different machines.

I'll try #541 but I seem to recall having issues on my end with the syncing

@forsyth2
Copy link
Collaborator

Ok I think I was successful syncing data to Perlmutter, but I can't log into Compy at the moment.

@chengzhuzhang
Copy link
Collaborator Author

Looks like I still have compy access, I just synced the data there. I guess you could focus on Perlmutter for now...

@forsyth2
Copy link
Collaborator

Thanks @chengzhuzhang. I emailed PNNL support for Compy. And yes, I'm working on the Chrysalis and Perlmutter pre-RC tests in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants