-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for ilamb tasks #574
Conversation
@forsyth2 this PR is ready for review. I tested using a v3 piControl run with 2 cases, first one remaping the v3 ELM data to 180x360_aave. The other with native regular lat-lon v3 ELM output. Both runs were successful. Except i still run into the ilamb issue, which was filed with ilamb developers.rubisco-sfa/ILAMB#86 I also update the ilamb DATA at lcrc input server, for a recent fix (rubisco-sfa/ILAMB#89), which should remember to propagate to other machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From visual inspection of the code, and since you already tested on a couple cases, this looks good to me. I can more thoroughly test as part of the zppy RC testing tomorrow. So, I think this is good to merge.
I'm assuming it's ok to proceed with making a zppy RC despite the ILAMB issue (rubisco-sfa/ILAMB#86)? (Users will just have to be aware of the bug in ILAMB).
I also update the ilamb DATA at lcrc input server, for a recent fix (rubisco-sfa/ILAMB#89), which should remember to propagate to other machines.
Is that something that needs to be done as part of the RC testing/release process then? What is involved with that?
Sounds good!
Yes, the ILAMB issue is most likely out of our hands.
Yes, before testing, it would be nice to sync the data to different machines. |
@chengzhuzhang Thanks, I just merged this PR
I'll try #541 but I seem to recall having issues on my end with the syncing |
Ok I think I was successful syncing data to Perlmutter, but I can't log into Compy at the moment. |
Looks like I still have compy access, I just synced the data there. I guess you could focus on Perlmutter for now... |
Thanks @chengzhuzhang. I emailed PNNL support for Compy. And yes, I'm working on the Chrysalis and Perlmutter pre-RC tests in the meantime. |
In this PR:
A bug is fixed in testing a piControl run when the start and end year needs to be padded with 0.
Add supports to grids other than 180x360_aave for ilamb tasks.