Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created two new nodes #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Created two new nodes #12

wants to merge 3 commits into from

Conversation

mcerin
Copy link

@mcerin mcerin commented Mar 4, 2021

No description provided.

@mcerin mcerin closed this Mar 4, 2021
@mcerin mcerin reopened this Mar 4, 2021
klemenkenda
klemenkenda requested changes Mar 4, 2021
View reviewed changes
Copy link
Collaborator

@klemenkenda klemenkenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are the comments. Also add unit tests for each new node that was implemented.

src/fusion/index.smartlamp.EMA.1d.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNaiadesWeatherNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNaiadesWeatherNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNaiadesWeatherNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNoiseNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNoiseNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNoiseNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingNoiseNode.js Outdated Show resolved Hide resolved
src/fusion/nodes/streamingTimeValueNode.js Outdated Show resolved Hide resolved
src/fusion/streamFusion.js Outdated Show resolved Hide resolved
@mcerin
Copy link
Author

mcerin commented Mar 10, 2021

I added one additional node and wrote unit tests for all new nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemenkenda klemenkenda klemenkenda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcerin @klemenkenda