DYN-7403: Add analytics to measure graph execution time #15902
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7403
| @@ -195,6 +196,9 @@ internal bool Execute() | |||
| finally | |||
| { | |||
| ExecutionEndTime = scheduler.NextTimeStamp; | |||
|
|
|||
| var elapsedTime = new TimeSpan(ExecutionEndTime.TickCount - ExecutionStartTime.TickCount); | |||
| Analytics.TrackTimedEvent(Categories.Performance, Actions.UpdateGraphAsyncTask.ToString(), elapsedTime, "Dynamo graph execution time"); | |||
| } | |||
There was a problem hiding this comment.
@QilongTang is there a way to retrieve the host info here? One of the asks for this task is to also determine whether these graph execution requests are being made from Dynamo (host or sandbox) or Player, etc.
There was a problem hiding this comment.
HostInfo is available from DynamoModel, but I think when we discuss that with @deepakanand earlier, he prefer to not use HostAnalyticsInfo object to identify player. Maybe he has some other thoughts in mind about implementation
| /// <summary> | ||
| /// Timed event: tracks view startup time | ||
| /// </summary> | ||
| ViewStartup, |
There was a problem hiding this comment.
Thanks for the clean up, we need to add these new waypoints to Analytics.NET repo
Purpose
Add analytics to measure graph execution time.
The waypoints used in this PR already exist.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add analytics to measure graph execution time.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of