Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-6370] Restore UI change in group context menu #15898

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

This PR addresses DYN-6370 where some of the items in the group context menu have darker background that the rest.

Issue :
The inconsistency is there because the Package Manager context menus (which should be dark grey) share the same context menu item style as the group, connector, connector pin, and 3D watch node context menus (which should be light grey).

Fix :
I've created a separate style that applies a darker background color when IsMouseOver = False. It can be reused for future dark grey context menus.

DYN-6370-Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

All items in the group, connector, connector pin and 3D watch node context menus now have consistent light grey backgrounds.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov
@achintyabhat

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant