Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to fix nuget pack for mutli targeted package #15887

Merged
merged 9 commits into from
Mar 4, 2025
Merged

attempt to fix nuget pack for mutli targeted package #15887

merged 9 commits into from
Mar 4, 2025

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Mar 4, 2025 •
edited
Loading

PR does the following:

  • adds multi targeted binaries in the intermediate base path to the sign list
  • modifies nuspec files pahts to be relative to harvest path, not bin path -as that is the path used when running the master-15 build pack step.

I don't know how to test these changes without merging this PR so I may need to send a few followups depending on what we see on master-15 unless someone has a better idea?

@mjkkirschner mjkkirschner requested review from zeusongit and sm6srw March 4, 2025 19:18
sm6srw
sm6srw approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjkkirschner mjkkirschner merged commit 1a071b4 into DynamoDS:master Mar 4, 2025
21 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm6srw sm6srw sm6srw approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkkirschner @sm6srw