Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-8298: Fix python node script editor displays wrong script when closed as unsaved #15875

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

zeusongit
Copy link
Contributor

Purpose

The following changes are made in the PR to fix the issue:

  • The modified script is now provided using EventArgs instead of sender.
  • The script returns to saved state, when a user closes the script editor without saving the changes.
  • Added comments/cleanup

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix python node script editor displays wrong script when closed as unsaved

Reviewers

@DynamoDS/dynamo

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8298

@zeusongit zeusongit marked this pull request as ready for review March 3, 2025 02:56
@reddyashish reddyashish added this to the 3.5 milestone Mar 3, 2025
@zeusongit zeusongit merged commit 91bca1d into DynamoDS:master Mar 3, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants