Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-8275 HTML Localization Controls #15867

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Source Level Localization of html files located in the Controls folder (html for FileTrustWarning and NodeAutocomplete)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Source Level Localization of html files located in the Controls folder (html for FileTrustWarning and NodeAutocomplete)

Reviewers

@QilongTang @reddyashish

FYIs

@ZbynekHanak-RWS

I've added the html files for each language as embedded resources in the DynamoCoreWpf project.
I've added the Copy Tasks for copying html files from Dynamo\doc\distrib\html\en-US\Controls to Dynamo\src\DynamoCoreWpf\Controls\Docs.
Updating Copy Task due that was copying to a wrong location
Updating the DSCoreNodes.xml due that a new node was added recently
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8275

@RobertGlobant20
Copy link
Contributor Author

@QilongTang @reddyashish
any comment about this changes?

@reddyashish
Copy link
Contributor

Looks good to me. @QilongTang Any comments?

@QilongTang
Copy link
Contributor

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

I think we need the files right now in Controls\Docs\cs-CZ just for compiling reasons, later (when loc team merge the html for all languages) won't be important to have them due that we have instructions that will copy the files from doc/distrib/html/cs-CZ/Controls to Controls\Docs\cs-CZ, the only important part is that we need the files as embedded resources in the csproj.
I included those files due that otherwise BuildDynamo check will fail due that we don't have all the html files in doc/distrib/html/cs-CZ/Controls right now and the compiler will detect that we are missing embedded resources.

@QilongTang
Copy link
Contributor

@RobertGlobant20 Do we need localized html in repo path like Controls\Docs\cs-CZ? I thought they will be only at doc/distrib/html/cs-CZ/Controls?

I think we need the files right now in Controls\Docs\cs-CZ just for compiling reasons, later (when loc team merge the html for all languages) won't be important to have them due that we have instructions that will copy the files from doc/distrib/html/cs-CZ/Controls to Controls\Docs\cs-CZ, the only important part is that we need the files as embedded resources in the csproj. I included those files due that otherwise BuildDynamo check will fail due that we don't have all the html files in doc/distrib/html/cs-CZ/Controls right now and the compiler will detect that we are missing embedded resources.

Gotcha, thanks!

@QilongTang QilongTang merged commit 387a5c7 into DynamoDS:master_cl Mar 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants