DYN-5807 : improve auto complete auto layout #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-5807
QilongTang
reviewed
Feb 27, 2025
QilongTang
reviewed
Feb 27, 2025
src/DynamoCoreWpf/ViewModels/Search/NodeSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
zeusongit
reviewed
Feb 27, 2025
| } | ||
| } | ||
|
|
||
| Rect2D connectedNodesBBBox = ComputeNodesBBox(connectedNodesToConsider); |
There was a problem hiding this comment.
maybe use a better name here? like
Rect2D NodesBoundingBox =GetNodesBoundingBox(connectedNodesToConsider);
There was a problem hiding this comment.
I recognize a copilot suggestion here! :))
QilongTang
reviewed
Feb 28, 2025
QilongTang
reviewed
Feb 28, 2025
| return parameter as PortModel != null ? portModel.CanAutoCompleteInput() : true; | ||
| } | ||
|
|
||
| private Rect2D GetNodesBoundingBox(IEnumerable<NodeModel> nodes) |
There was a problem hiding this comment.
Looking great! Thank you for splitting these up. Would you add some comments to these new functions?
|
Would you attach a gif for the behavior change? Appreciate it |
9 tasks
QilongTang
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve auto complete auto layout in such way that fewer nodes overlap as a result of placing a new node suggested by auto complete. Also we do not want to launch auto complete if the port is an input port which already has a connection.
We will create a small ripple effect only in the area of the affected node that includes the node itself , the connected nodes on the affected side and some other nodes that are in this area.
Old Behaviour :
New Behaviour :
Declarations
Check these if you believe they are true
*.resxfiles