[DYN-7923] CurveMapper node #15863
[DYN-7923] CurveMapper node #15863
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7923
| if (ResetButton.ToolTip is ToolTip resetTooltip) | ||
| { | ||
| resetTooltip.Content = curveMapperNodeModel.IsLocked | ||
| ? "The curve has been locked and cannot be reset. Please unlock the curve first." |
There was a problem hiding this comment.
These need to be moved to resources, so that it can be localized.
|
|
||
| namespace DSCore.CurveMapper | ||
| { | ||
| public class PerlinNoiseCurve : CurveBase |
There was a problem hiding this comment.
@ivaylo-matov Thank you for adding detailed comments, can we add a class summary to the different curve models used in this node. Would be useful as they are exposed as public.
There was a problem hiding this comment.
Thanks @reddyashish, I've added the summaries.
The resorces and localization will come in the next PR. Hope that's okay.
|
Looks good overall, can merge and get it to testing once the comment is addressed. |
|
Some failing tests here: Seems unrelated, but can you verify them locally? |
|
@reddyashish , locally only one of those tests fails. The fail is not related to CurveMapper though, as it fails with or without it.
|
|
Merging this PR to get the testing started on the new node. |
Purpose
This PR addresses DYN-7923. It implements the Graph Map node from Celery as a built-in Dynamo node.
The new CurveMapper node redistributes a series of numbers based on predefined curve equations. The available curve types include Linear, Bezier, Sine, Cosine, Parabolic, Perlin Noise, Gaussian, Power, and Square Root. Users can adjust the curves interactively using interactive handles. Additional controls allow users to lock curves, reset them, and resize the node.
The UI, styling, and tooltips align with the design specifications outlined in Figma.
As agreed, resources and unit tests will be included in subsequent PRs.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
This PR addresses DYN-7923. It implements the Graph Map node from Celery as a built-in Dynamo node.
The new CurveMapper node redistributes a series of numbers based on predefined curve equations. The available curve types include Linear, Bezier, Sine, Cosine, Parabolic, Perlin Noise, Gaussian, Power, and Square Root. Users can adjust the curves interactively using interactive handles. Additional controls allow users to lock curves, reset them, and resize the node.
The UI, styling, and tooltips align with the design specifications outlined in Figma.
As agreed, resources and unit tests will be included in subsequent PRs.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov
@achintyabhat