Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Geometry.IsAlmostEqualTo Sample #15738

Merged

Conversation

johnpierson
Copy link
Member

Purpose

To fix the Geometry.IsAlmostEqualTo sample. The description was a copy of Vector.IsAlmostEqualTo

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@achintyabhat

FYIs

@Amoursol

Previously the sample's description was a verbatim copy of Vector.IsAlmostEqual to.

FYI @Amoursol
Copy link

github-actions bot commented Dec 27, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.5 milestone Jan 7, 2025
@QilongTang
Copy link
Contributor

Nice fix. Please hold on merging this PR since Morpheus team is updating localization pipeline and process, will come back to this

@QilongTang QilongTang added DNM Do not merge. For PRs. and removed DNM Do not merge. For PRs. labels Jan 7, 2025
@QilongTang
Copy link
Contributor

@johnpierson Now that node help localization pipeline changes are done, would you update this PR to aim the file under en-US folder instead of root folder?

@johnpierson
Copy link
Member Author

johnpierson commented Jan 9, 2025 via email

@QilongTang QilongTang merged commit 4c807c0 into DynamoDS:master Jan 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants