fix ContainsEmptyListOrNullTest sproadic failures #14946
Conversation
| libraries.Add("DesignScriptBuiltin.dll"); | ||
| libraries.Add("DSCoreNodes.dll"); | ||
| base.GetLibrariesToPreload(libraries); | ||
| } |
There was a problem hiding this comment.
these are needed by some of the graphs opened during GraphNodeManagerViewExtensionTests tests
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
@aparajit-pratap any ideas how to fix the API break analysis ? |
I can send a PR to fix those errors. Basically, if you use the CodeFix option on the squiggly line in VS for each of those errors, they'll automatically be added to the unshippedAPI.txt file. |
I do not see any compiler issues in VS (no squiggly lines). Not sure where or how ... |
You're right, I don't see them either for the typeforwarded types. Maybe the analyzer works differently for these cases 🤷 |
Enforced MMVM pattern : removed GNMView usage in GNMViewModel
Removed redundant instantiation of GNMView and GNMViewModel in extension code
Reset the EnablePersistExtensions flag in tests
Removed redundant RaiseLoadedEvent calls in tests
Added preloaded libs for GNMVE tests
Made GNMView disposable