Let these commands fail upward

DustinBrett · Oct 19, 2024 · ef3e81e · ef3e81e
1 parent 7e1220c
commit ef3e81e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 25 deletions.
diff --git a/utils/ffmpeg/index.ts b/utils/ffmpeg/index.ts
@@ -43,17 +43,13 @@ export const transcode = async (
       const baseName = basename(fileName);
       const newName = `${basename(fileName, extname(fileName))}.${extension}`;
 
-      try {
-        ffmpeg.FS("writeFile", baseName, fileData);
-        await ffmpeg.run("-i", baseName, newName);
-
-        returnFiles.push([
-          join(dirname(fileName), newName),
-          Buffer.from(ffmpeg.FS("readFile", newName) as Uint8Array),
-        ]);
-      } catch {
-        // Ignore failure while reading/writing files
-      }
+      ffmpeg.FS("writeFile", baseName, fileData);
+      await ffmpeg.run("-i", baseName, newName);
+
+      returnFiles.push([
+        join(dirname(fileName), newName),
+        Buffer.from(ffmpeg.FS("readFile", newName) as Uint8Array),
+      ]);
     })
   );
 

diff --git a/utils/sheetjs.ts b/utils/sheetjs.ts
@@ -31,18 +31,9 @@ export const convertSheet = async (
     numbers = window.XLSX_ZAHL_PAYLOAD;
   }
 
-  // eslint-disable-next-line no-undef-init
-  let sheet: Uint8Array | undefined = undefined;
-
-  try {
-    sheet = sheetJs.write(sheetJs.read(fileData), {
-      bookType: extension as XLSX.BookType,
-      numbers,
-      type: "buffer",
-    }) as Uint8Array;
-  } catch {
-    // Ignore failure to read/write sheet
-  }
-
-  return sheet || Buffer.from("");
+  return sheetJs.write(sheetJs.read(fileData), {
+    bookType: extension as XLSX.BookType,
+    numbers,
+    type: "buffer",
+  }) as Uint8Array;
 };