Fix null reference exception in event service when httpcontext missing #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brockallen
approved these changes
May 21, 2024
|
mainline or 7.0.x branch? |
josephdecock
force-pushed
the
joe/nre-httpcontext
branch
from
33d0d5d to
6b31768
Compare
7.0.x - I've rebased... |
|
Hmm, now too many commits are here |
josephdecock
force-pushed
the
joe/nre-httpcontext
branch
from
6b31768 to
1fb773d
Compare
|
Okay, all better now. |
brockallen
approved these changes
May 21, 2024
|
Oh wait -- it's still against main? |
|
Thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DuendeSoftware/Support#614, which seems to have reappeared for events.