SylkParser bug fixes #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have example .slk files which use these tags? I know the implementation is incomplete because I only intended to load the .slk files from wc3, which only use the ID, B, C, and E tags. |
|
SLK Files.zip I can also get you examples from custom maps, if needed. |
speige
force-pushed
the
SylkParser_bug_fixes
branch
6 times, most recently
from
f21bf4e to
9711ef3
Compare
…s tags, like formatting.
speige
force-pushed
the
SylkParser_bug_fixes
branch
from
9711ef3 to
7110797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make SylkParser more robust to handle malformed files & ignore useless tags, like formatting.