Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fight Command #2719

Draft
wants to merge 68 commits into
base: draftbot-v5
Choose a base branch
from
+2,157 −844

fight points -> energy #2777

f003a2c
Select commit
Loading
Failed to load commit list.
Draft

Fight Command #2719

fight points -> energy #2777
f003a2c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (draftbot-v5) failed Mar 1, 2025 in 39s

CodeScene PR Check

Quality Gate Failed

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (1 hotspot with Large Method, Excess Number of Function Arguments)
Enforce critical code health rules (1 file with Bumpy Road Ahead)
Enforce advisory code health rules (4 files with Large Method, Excess Number of Function Arguments, Complex Method, Overall Code Complexity, Primitive Obsession, String Heavy Function Arguments)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
Player.ts 2 rules in this hotspot 7.21 → 6.98 Suppress
Enforce critical code health rules Violations Code Health Impact
FightCommand.ts 1 critical rule 10.00 → 9.84 Suppress
Enforce advisory code health rules Violations Code Health Impact
FightView.ts 2 advisory rules 10.00 → 8.85 Suppress
StringUtils.ts 2 advisory rules 9.69 → 9.10 Suppress
DraftbotHistoryCachedMessage.ts 1 advisory rule 10.00 → 9.66 Suppress
Player.ts 2 advisory rules 7.21 → 6.98 Suppress
View Improvements
File Code Health Impact Categories Improved
LogsReadRequests.ts no change String Heavy Function Arguments
FightController.ts no change Complex Method
eruptionAttack.ts 9.69 → 10.00 Excess Number of Function Arguments

Absence of Expected Change Pattern

  • DraftBot/Core/src/core/fights/actions/interfaces/players/ultimateAttack.ts is usually changed with: DraftBot/Core/src/core/fights/actions/interfaces/players/sabotageAttack.ts, DraftBot/Core/src/core/fights/actions/interfaces/players/chargingAttack.ts, DraftBot/Core/src/core/fights/actions/interfaces/players/powerfulAttack.ts, DraftBot/Core/src/core/fights/actions/interfaces/players/chargeChargingAttack.ts

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

View more details on CodeScene Delta Analysis