Report command part 1 #2425
Merged
Report command part 1 #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiryn
added
command
|
J'ai pas le temps de passer sur eslint et tous les scans donc je propose un fix général à la fin de la v5 |
|
13k lignes 😭 |
|
GL |
|
Mais en vrai tu peux me faire confiance je code pas trop mal |
BastLast
approved these changes
Feb 27, 2024
Comment on lines
-3
to
-7
| "goblets": { | ||
| "metal": "🐲", | ||
| "biggest": "🪣", | ||
| "sparkling": "✨" | ||
| }, |
There was a problem hiding this comment.
faudrait vraiment faire tout ça en plusieurs pr pr mieux review parce que par commande je pense pas que ça soit le bon move, une pr pr déplacer les émojis, une pour transférer les jsons ça serait mieux imo
There was a problem hiding this comment.
Les modifs de la v5 sont trop grosses, quand je modifie un petit bout ça tire un autre bout qui tire un autre bout qui tire un autre bout qui... Et si je commence à faire 1 PR par petit bout j'ai pas fini. Surtout que ça veut dire commit du code qui ne marche pas encore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.