fix: Disallow javascript: navigation in marvin by default #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to ask marvin to visit a
javascript:
url (e.g.javascript:console.log(1)
). This poses a potential challenge bypass for certain configurations of challenges. It is safer to just disallow this behavior by default.This behavior was originally intended to be banned by a request interceptor, however it turns out the request interceptor doesn't trigger for
javascript:
urls 😠. Instead this introduces a precheck validator that blocks the visit request prior to the browser attempting to visiting the page.This change also fixes up some local dev niceties (its a bit noisy but i cbsd making another pr).
Example bug reproduction:
Client
Old State
Server
New State