Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Some Genetics Infusions to Animalistic Traits #379

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

Nerev4r
Copy link
Collaborator

@Nerev4r Nerev4r commented Jan 27, 2025

About The Pull Request

This PR was going to include the rest of them then I realized 'yeah no hang on wait a minute.'

Why It's Good For The Game

However, space carp and the roach one are sort of self-balancing (you fucking choke to death in station atmos with the carp infusion)/weak respectively, and might lead to some interesting(ly fucked up) genemodders.

Changelog

🆑
add: You can get the carp infusion and roach infusion from animalistic traits now.
/:cl:

@carpotoxin
Copy link
Collaborator

carpotoxin commented Jan 27, 2025

how does carp differ from fish and how does roach differ from bug? why does roach not get MOB_BUG biotype?

Copy link
Collaborator

@carpotoxin carpotoxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_species.dm li 111 from if(BUG) to if(BUG || ROACH), li 121 from if(FISH) to if(FISH || CARP).

Copy link
Collaborator

@carpotoxin carpotoxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change the bug icon to be different from the roach.
image

Copy link

github-actions bot commented Feb 6, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Feb 6, 2025
@carpotoxin carpotoxin removed the Stale label Feb 8, 2025
@Ephemeralis Ephemeralis merged commit 5cacfde into DopplerShift13:master Feb 11, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants