Bypasses All* of the Techweb. #369
Conversation
Automatic TGS DMAPI Update
| return ..() | ||
|
|
||
| /datum/techweb/round_start | ||
| var/list/researched_nodes = list(TECHWEB_NODE_AI , |
There was a problem hiding this comment.
similarly here, researched_nodes is already a declared list variable, it's complaining cause you're redeclaring it
the following should do it
| var/list/researched_nodes = list(TECHWEB_NODE_AI , | |
| researched_nodes = list(TECHWEB_NODE_AI, |
and probably remove the unneeded spaces in front of all of these commas
THAT SAID
a big hardcoded list of IDs is not a good way to do this, researches might get added or removed or whatever
probably wanna go through all nodes and add the ones without hidden = TRUE or experimental = TRUE, or trawl through the tech tree for ones you could research
SSresearch should have a list of hidden and experimental nodes already:
DopplerShift/code/controllers/subsystem/research.dm
Lines 33 to 36 in 3908b86
There was a problem hiding this comment.
ALSO this probably wouldn't work as intended anyway
researched_nodes is an associative list where each ID is associated with TRUE when researched
look here for how the default and admin techwebs handle it for an example on what it does to assemble its list of researches
DopplerShift/code/modules/research/techweb/techweb_types.dm
Lines 30 to 34 in 3908b86
DopplerShift/code/modules/research/techweb/_techweb.dm
Lines 80 to 84 in 3908b86
Co-authored-by: _0Steven <[email protected]> Signed-off-by: Exo-212 <[email protected]>
Exo-212
requested review from
carpotoxin,
Ephemeralis and
Paxilmaniac
as code owners
There was a problem hiding this comment.
Please make a new folder and file called techweb_bypass(.dm) inside modular_doppler and instead put all the additions in that new file.
/// Medical Modular Suit
/datum/techweb_node/mod_medical
starting_node = TRUE
/// Engineering Modular Suits
/datum/techweb_node/mod_engi
starting_node = TRUE
That way we don't have these non-modular edits, that can easily be added to an organized overwrite file within our modular folder structure.
I can get to this during the week |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
Is this still being worked on?
…On Fri, Jan 24, 2025 at 8:23 AM Exo-212 ***@***.***> wrote:
About The Pull Request
Created the License Authenticator Disk to research nodes without the busy
work of running experiments and the research queue. The LAD can be found in
the RD's locker, and when uploaded to the station's techweb unlocks every
node with the exception of:
Alien Technology
Alien Engineering
Alien Surgery
BEPIS (Now Bitrunner) Tech
Illegal/Syndicate Tech
Unregulated Bluespace Research
Why It's Good For The Game
Tedium is bad, actually.
Changelog
🆑
Add: the LAD disk, to be found in RD lockers.
/:cl:
------------------------------
You can view, comment on, or merge this pull request online at:
#369
Commit Summary
- 17aca9b
<17aca9b>
Update TGS DMAPI
- 43650b5
<43650b5>
Merge pull request #2 from Exo-212/tgs-dmapi-update
- 54f46df
<54f46df>
Merge branch 'DopplerShift13:master' into master
- 4b8a9cf
<4b8a9cf>
Maybe puts a techweb override disk in
- 6e20ec9
<6e20ec9>
get less ambitious and do the smaller goal
- d029fda
<d029fda>
big list
- ee324d7
<ee324d7>
what I got rn
File Changes
(4 files <https://github.com/DopplerShift13/DopplerShift/pull/369/files>)
- *M* code/controllers/subsystem/research.dm
<https://github.com/DopplerShift13/DopplerShift/pull/369/files#diff-ca1f526eeaca89ce1d70f7c50f956953089539d7fb88a553158c4bfe5961a152>
(1)
- *M*
code/game/objects/structures/crates_lockers/closets/secure/scientist.dm
<https://github.com/DopplerShift13/DopplerShift/pull/369/files#diff-1fd76dd4af4cf7cbede664008a5d868328a50bd3470d73a2f59006e6b59e866c>
(1)
- *A* modular_doppler/research/techweb/techweb_bypass.dm
<https://github.com/DopplerShift13/DopplerShift/pull/369/files#diff-1d4cecaa1e553ac3536ca80b3c965be08a71c487df8d1280e727293044505be5>
(115)
- *M* tgstation.dme
<https://github.com/DopplerShift13/DopplerShift/pull/369/files#diff-043dca501e2c965d2004447c47395ee146e574a58a846c0766c4643e9d66518e>
(1)
Patch Links:
- https://github.com/DopplerShift13/DopplerShift/pull/369.patch
- https://github.com/DopplerShift13/DopplerShift/pull/369.diff
—
Reply to this email directly, view it on GitHub
<#369>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX2ZTRXEPGV4ELVEEGR3GHD2MGIYTAVCNFSM6AAAAABVYT64JKVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAYDQMRYGMYDMNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
oop, yes, sorry. gotta get it modular |
|
honestly more work to undo my previous work, fresh PR time |
About The Pull Request
Unlocks nearly all the techweb nodes at the start of the round.
Did not include the following techweb nodes:
TECHWEB_NODE_CYBER_ORGANS_ADV
(x-ray and thermals cyber eyes)
TECHWEB_NODE w/ Experimental = True
(All Tech Derived from Bitrunning Disks a.k.a. ‘bepis-tech’)
TECHWEB_NODE_ALIENTECH and children nodes
(Alien Tech)
TECHWEB_NODE_MECH_CLOWN
(Honk Mech is for clowns to pester science to unlock)
TECHWEB_NODE_MOD_ENTERTAINMENT
(Same as Honk Mech)
TECHWEB_NODE_SYNDICATE_BASIC
(It’s syndicate tech, not PA tech.)
TECHWEB_NODE_UNREGULATED_BLUESPACE
(Surely we don’t have any unregulated tech on file)
Changelog
🆑
Change: most regularly researchable tech is now unlocked at roundstart
Same: Experiments are not autocompleted if Science players still want to do them.
/:cl: