Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve equality checks involving tuples, vectors, intervals, and arrays #270

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

dqnykamp
Copy link
Member

@dqnykamp dqnykamp commented Dec 9, 2024

This PR upgrades math-expressions to a version has improved equality checks for tuples and related. The following changes where made:

  • tuples, vectors, altVectors, and open intervals are considered identical even deep inside a mathematical expression
  • arrays and closed intervals are considered identical even deep inside a mathematical expression
  • tuples, vectors, altVectors, and open intervals are treated as identical when sorting
  • arrays and closed intervals are considered identical when sorting.

In addition, the complex numerical answer validation will always be available if symbolicEquality is not specified, even if the expression contains operators such as logical or set operators.

Fixes #168

@dqnykamp dqnykamp merged commit 5374278 into Doenet:main Dec 11, 2024
3 checks passed
@dqnykamp dqnykamp deleted the vector_equality branch December 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equality of <subsetOfReals> objects (intervals vs tuples)
1 participant