Make open keyboard button more visible #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siefkenj
reviewed
Aug 2, 2024
| @@ -64,6 +63,8 @@ Tailwind base is purposely not included because we want all styles to be prefixe | |||
| @apply border-b-black border-b; | |||
| @apply hover:bg-slate-300 active:bg-slate-400; | |||
| @apply w-12 h-[1.5rem] flex items-center justify-center; | |||
| background-color: white; | |||
There was a problem hiding this comment.
This is fine. You can also do bg-white inside of an @apply block to do it tailwind style.
There was a problem hiding this comment.
I was wondering about the @apply, but figured you'd let me know!
There was a problem hiding this comment.
Is there a border-width @apply version I should use as well?
There was a problem hiding this comment.
|
Looks good. |
dqnykamp
added a commit
that referenced
this pull request
Aug 15, 2024
Backport of #232 to 0.6 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the open keyboard button be white with a black border to make it more visible, especially when it is in front of a dark background.