Travis remove slack notifications #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
I am against this until #4722 fails to offer a solution. |
|
I have no idea why coverage fails to report the correct coverage. Travis build 56.1 and 56.2 both report 77% coverage |
The slack notifications being hard-coded in travis resulted in every forked build on travis also sending the notifications to the slack channel. Since there is no way to limit notifications to master repo, the notifications should be removed altogether. Note: The build status is visible on every PR request, so PR can still be checked for build errors Resolves #22 Signed-off-by: Harshvardhan Pandit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no way to restrict slack notifications from forked builds, I vote to remove the slack notification to reduce spam. Refers to #22