Test enhancement

DivineOmega · Mar 19, 2020 · 8bf5c55 · 8bf5c55
1 parent 4ae85ce
commit 8bf5c55
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,6 @@
 language: php
-dist: trusty
 php:
-  - '7.1.18'
+  - '7.1.33'
   - '7.2'
   - '7.3'
   - nightly

diff --git a/composer.json b/composer.json
@@ -33,7 +33,7 @@
         "divineomega/psr-18-guzzle-adapter": "^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^6.5",
+        "phpunit/phpunit": "^7.0||^8.0",
         "fzaninotto/faker": "^1.7",
         "vimeo/psalm": "^1",
         "kriswallsmith/buzz": "^1.0",

diff --git a/tests/Unit/CustomInjectionsTest.php b/tests/Unit/CustomInjectionsTest.php
@@ -21,8 +21,8 @@ public function testConnection()
 
         $passwordExposedChecker = new PasswordExposedChecker(null, $cache);
 
-        $this->assertEquals(true, $passwordExposedChecker->isExposed('hunter2'));
-        $this->assertEquals(false, $passwordExposedChecker->isExposed($this->getPasswordHashUnlikelyToBeExposed()));
+        $this->assertTrue($passwordExposedChecker->isExposed('hunter2'));
+        $this->assertFalse($passwordExposedChecker->isExposed($this->getPasswordHashUnlikelyToBeExposed()));
     }
 
     public function testCustomLibrary()

diff --git a/tests/Unit/PasswordExposedByHashTest.php b/tests/Unit/PasswordExposedByHashTest.php
@@ -13,7 +13,7 @@ class PasswordExposedByHashTest extends TestCase
     /** @var PasswordExposedChecker */
     private $checker;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $cache = new CacheItemPool();
         $cache->changeConfig(
@@ -51,8 +51,8 @@ public function testExposedPasswords($hash)
     {
         $this->assertEquals($this->checker->passwordExposedByHash($hash), PasswordStatus::EXPOSED);
         $this->assertEquals(password_exposed_by_hash($hash), PasswordStatus::EXPOSED);
-        $this->assertEquals($this->checker->isExposedByHash($hash), true);
-        $this->assertEquals(password_is_exposed_by_hash($hash), true);
+        $this->assertTrue($this->checker->isExposedByHash($hash));
+        $this->assertTrue(password_is_exposed_by_hash($hash));
     }
 
     public function testNotExposedPasswords()

diff --git a/tests/Unit/PasswordExposedTest.php b/tests/Unit/PasswordExposedTest.php
@@ -13,7 +13,7 @@ class PasswordExposedTest extends TestCase
     /** @var PasswordExposedChecker */
     private $checker;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $cache = new CacheItemPool();
         $cache->changeConfig(
@@ -46,8 +46,8 @@ public function testExposedPasswords($password)
     {
         $this->assertEquals($this->checker->passwordExposed($password), PasswordStatus::EXPOSED);
         $this->assertEquals(password_exposed($password), PasswordStatus::EXPOSED);
-        $this->assertEquals($this->checker->isExposed($password), true);
-        $this->assertEquals(password_is_exposed($password), true);
+        $this->assertTrue($this->checker->isExposed($password));
+        $this->assertTrue(password_is_exposed($password));
     }
 
     public function testNotExposedPasswords()