Merge pull request #34 from hph86/fix-time-comparison

src/rating - Use UTC time for comparison with x509 certs
DinoTools · Feb 11, 2016 · 884b13a · 884b13a
2 parents 46b9d46 + 621ae50
commit 884b13a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sslscan/module/rating/builtin.py b/sslscan/module/rating/builtin.py
@@ -59,7 +59,7 @@ def __init__(self, **kwargs):
             RatingRule(
                 "server.certificate.x509.not_after",
                 rules=[
-                    lambda v, i, kb: 6 if v < datetime.now() else None
+                    lambda v, i, kb: 6 if v < datetime.utcnow() else None
                 ],
             )
         )
@@ -68,7 +68,7 @@ def __init__(self, **kwargs):
             RatingRule(
                 "server.certificate.x509.not_before",
                 rules=[
-                    lambda v, i, kb: 6 if v > datetime.now() else None
+                    lambda v, i, kb: 6 if v > datetime.utcnow() else None
                 ],
             )
         )

diff --git a/sslscan/module/rating/ssllabs.py b/sslscan/module/rating/ssllabs.py
@@ -154,7 +154,7 @@ def __init__(self, **kwargs):
             RatingRule(
                 "server.certificate.x509.not_after",
                 rules=[
-                    lambda v, i, kb: 6 if v < datetime.now() else None
+                    lambda v, i, kb: 6 if v < datetime.utcnow() else None
                 ],
             )
         )
@@ -163,7 +163,7 @@ def __init__(self, **kwargs):
             RatingRule(
                 "server.certificate.x509.not_before",
                 rules=[
-                    lambda v, i, kb: 6 if v > datetime.now() else None
+                    lambda v, i, kb: 6 if v > datetime.utcnow() else None
                 ],
             )
         )