Skip to content

Commit

Permalink
Adds clarification on how unit tests should be handled
Browse files Browse the repository at this point in the history
  • Loading branch information
digicontributer committed Jul 22, 2021
1 parent 76029cb commit a861368
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions doc/bitcoin-upstream-merge.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,11 @@ Key Areas to look out for Merge Conflict / Compiler Bugs:

8. Go error by error and fix each compiler bug and make a commit that clearly explains what was wrong and how it was fixed and how it was broken in the merge. This will help educate everyone else on what to look out for in the future and if there were any other major changes Bitcoin made that break other things in DGB.

9. Once the client is compiling from the command line, now try the GUI and test, test and test some more. Now it's time to get gitian building working.
9. If your commit contains any Unit Tests ensure they are all passing before sumbission and take particular care not just to fix the test so that it passes but to fix the code thats being tested against. Only change the test as a last resort and clearly explain your reasoning for doing so.

10. Now that you have a compiling upgraded version of DGB core, pat everyone on the back and go enjoy an ice-cold beer and celebrate.
10. Once the client is compiling from the command line, now try the GUI and test, test and test some more. Now it's time to get gitian building working.

11. Now that you have a compiling upgraded version of DGB core, pat everyone on the back and go enjoy an ice-cold beer and celebrate.


{"mode":"full","isActive":false}

1 comment on commit a861368

@mctrivia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Please sign in to comment.