HGETALL WATCH Support #1405
Draft
HGETALL WATCH Support #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JyotinderSingh - @asaurabh12 and I have made changes to watch_manager.go, constants.go and cmd_meta.go. The doubt we have is about eval.go because the file structure has changed from when the ZRANGE WATCH PR was designed. Should the changes be done in store_eval in this new design? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the HGETALL.WATCH command, allowing clients to watch whenever the data inside the respective hash set changes.
HGETALL Command doc - https://redis.io/docs/latest/commands/hgetall/