Added ByScore, Limit for ZRANGE #1396
Open
+294
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucifercr07 any improvements or any structure changes that needs to be done? |
|
@vanshavenger thanks for contributing, will have a look later today. |
apoorvyadav1111
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Hi @vanshavenger, Thank you for the changes. Would it be okay for you to add tests for this new functionality?
Thanks,
Apoorv
|
Sure give me this week time will add the tests. |
|
@apoorvyadav1111 can you check test once, locally it didn't throw any error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BYLEX is for now a placeholder but yes it is inlcuded as one of the option.
+inf, -inf, Exclusivity all cases handled.
Kindly check and review once.
My first time with Golang