-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for SMEMBERS.WATCH command #1289
Open
superiorsd10
wants to merge
7
commits into
DiceDB:master
Choose a base branch
from
superiorsd10:smembers-watch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+231
−44
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0dd5001
feat(eval): notify subscribers when SADD is performed in evalSADD fun…
superiorsd10 66a128b
feat(store): add SADD and SMEMBERS constants
superiorsd10 2a3d8b0
feat(watchmanager): include dstore.SADD in affectedCmdMap
superiorsd10 cc20c66
feat(worker): add CmdSMembersWatch to CommandsMeta and watch commands…
superiorsd10 e9b356a
test(integration): add tests for SMEMBERSWATCH and SMEMBERSWATCHWithSDK
superiorsd10 1423080
test(integration): remove sortSlice function, introduce testifyAssert…
superiorsd10 9edd2a5
feat(eval): made changes according to the latest rebase
superiorsd10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat(eval): notify subscribers when SADD is performed in evalSADD fun…
…ction
commit 0dd5001dfce9f00259d7ceb74a5529c134f1f6fa
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reformat this file? I'm seeing additional diffs here due to indentation changes which makes it harder to see the actual code changes.