-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix JSONPath inconsistencies #1266
base: master
Are you sure you want to change the base?
Conversation
We're not looking to support RESP3 at this stage. Let's stick with RESP2. Is RESP3 support a blocker in any way? |
Nope, definitely not a blocker. |
In that case we can remove the related code and limit this PR to just the jsonpath changes. |
Looks like the tests and linter are failing, could you please take a look? Also, is this PR ready for review? |
…djusted as per new structure
Hi Yes, Apologies, I was traveling the entire week so couldn't push. I have pushed the latest changes. Test cases required changes in output structure mainly. I ran linter on my local before pushing it through some warnings and error at other parts of the code. I am not sure why it didn't caught attention earlier. Currently, GitHub actions is seeking approval |
Thanks for the update! Since you've never pushed a commit into the repository before your PRs require a manual github actions run. |
Looks like there are some test failure, could you please take a look. |
There are two test cases failing:
|
@N3XT14 any updates on this? Please let us know if any help required on this. |
Hi @lucifercr07. The implementation and test cases are working. Latest commit: d5fa222 Furthermore, I am waiting for a response on the above two questions mentioned in previous comment. |
Hi @N3XT14, could you please rebase the PR on the latest commit? I'm wondering if some issues would automatically get fixed. |
@JyotinderSingh.
Sorry for the delay. I was busy with something urgent at work and couldn't give enough time.
Have a look at this PR. It's not completed yet but good portion of it is completed. Unfortunately, I am unable to find how to enable the resp3 protocol.
Also, in the Data Link shared the multi path examples seems incorrect in the array example.
Currently, I am testing it on my end but since certain parts such as RESP3 and custom formats are pending I am not asking for a merge yet.
I wanted to also open up a discussion on certain outputs that Redis returns such as for example "accessing negative index on out of bounds for an arrray example", etc.
Should we be following that as I believe we should instead return error for such cases instead of nil or the way redis handles.
Fixes #1002