Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pydantic version 2 #372

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Migrate to pydantic version 2 #372

wants to merge 14 commits into from

Conversation

stephen-riggs
Copy link
Contributor

This implements the changes needed for pydantic 2.

In doing this, we also upgrade to sqlalchemy 2, so one change has also been made for that.

Also this removes the procrunner dependency in favour of directly calling subprocess.

Before merging this we need to be able to run MSYS2 or a similar rust-compatible terminal on the microscopes.

Closes #315

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.

Project coverage is 27.18%. Comparing base (dd8f649) to head (846f7b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   27.32%   27.18%   -0.14%     
==========================================
  Files          78       78              
  Lines       10172    10244      +72     
  Branches     1354     1380      +26     
==========================================
+ Hits         2779     2785       +6     
- Misses       7298     7361      +63     
- Partials       95       98       +3     

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Pydantic 2
2 participants