Common XRC: Modify parameters and composite devices #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 86.94% 86.89% -0.06%
==========================================
Files 102 104 +2
Lines 6969 6988 +19
==========================================
+ Hits 6059 6072 +13
- Misses 910 916 +6
|
olliesilvester
commented
Feb 11, 2025
|
|
||
|
|
||
| @pydantic.dataclasses.dataclass(config={"arbitrary_types_allowed": True}) | ||
| class HyperionFlyScanXRayCentreComposite: |
There was a problem hiding this comment.
Not immediately obvious but we get circular imports without moving this
rtuck99
reviewed
Feb 13, 2025
rtuck99
reviewed
Feb 13, 2025
| GridscanParamConstants, | ||
| HardwareConstants, | ||
| ) | ||
|
|
||
| """Parameter models in this file are abstract. They should be inherited by a top-level model""" |
There was a problem hiding this comment.
This PR adds detector_params to SpecifiedThreeDGridScan, so this class isn't abstract anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #794
feature_dependant_configfunction toFeatureFlags, which handles configuration relying on the live feature settings. and is done before the XRC kicks offdetector_paramstoSpecifiedThreeDGridScan, using a dictionary mapping beamline to detector size. This meansSpecifiedThreeDGridScanis not abstract so can be used by other beamlines wanting to do XRCcommon