Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocentering gpu offload #184

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Vocentering gpu offload #184

merged 3 commits into from
Jan 15, 2025

Conversation

neon60
Copy link
Collaborator

@neon60 neon60 commented Jan 11, 2025

Improve performance of vo search

  • Use full mask
  • Use modified _calculate_metrics

I will validate these again:

Please ignore these files, I will delete them:

@neon60 neon60 force-pushed the vocentering_gpu_offload branch 2 times, most recently from aaa4532 to 6ae3cb1 Compare January 13, 2025 08:33
@dkazanc
Copy link
Collaborator

dkazanc commented Jan 13, 2025

thanks @neon60 I'm going through it now. We added real data tests into the library recently so I'll add that. Also will clean some comments as I go.

@namannimmo10 namannimmo10 added the run-zenodo-tests Run Zenodo tests for each PR label Jan 13, 2025
@namannimmo10
Copy link
Member

You must add a label to run the Zenodo tests - with 6ae3cb1 the big data tests didn't run. The tests will run only after you add the label and make a commit.

@namannimmo10 namannimmo10 force-pushed the vocentering_gpu_offload branch from 694e9ca to d788f39 Compare January 13, 2025 16:20
removing erroneous downsample kernel, adding performance test to zenodo tests

Co-authored-by: dkazanc <[email protected]>
@namannimmo10 namannimmo10 force-pushed the vocentering_gpu_offload branch from d788f39 to e55dec4 Compare January 13, 2025 16:22
@namannimmo10
Copy link
Member

Currently the CI fails because the performance test was collected

FAILED zenodo-tests/test_recon/test_rotation.py::test_center_vo_i12_dataset1_performance

@dkazanc dkazanc merged commit 51aad78 into main Jan 15, 2025
2 checks passed
@dkazanc dkazanc deleted the vocentering_gpu_offload branch January 15, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-zenodo-tests Run Zenodo tests for each PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants