Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I10 scaler card pc correction #1050

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Feb 10, 2025

Fixes #1048 , simple pv correction.

Instructions to reviewer on how to test:

  1. Run test
  2. Confirm connection

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny linked an issue Feb 10, 2025 that may be closed by this pull request
1 task
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (cdc6652) to head (b8123e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         160      160           
  Lines        6599     6599           
=======================================
  Hits         6446     6446           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relm-Arrowny Relm-Arrowny marked this pull request as ready for review February 10, 2025 09:36
@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner February 10, 2025 09:36
@Relm-Arrowny Relm-Arrowny changed the title corrected pv I10 scaler card pc correction Feb 10, 2025
Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Checked against the synoptic
image
and looks correct

@Relm-Arrowny Relm-Arrowny merged commit b6270c2 into main Feb 10, 2025
22 checks passed
@Relm-Arrowny Relm-Arrowny deleted the 1048-rasorscalercard1-not-read-correctly branch February 10, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RasorScalerCard1 not read correctly
2 participants