-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate the docs #448
migrate the docs #448
Conversation
stan-dot
commented
May 1, 2024
•
edited
Loading
edited
- squash the commits that change the contents - (all except the first one)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 40 40
Lines 1667 1667
=======================================
Hits 1518 1518
Misses 149 149 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git appears to see these as deleting old files and creating new ones, rather than renaming. Can we somehow preserve history?
we cannot preserve that, renaming the file extension makes the change. |
Can you try renaming the files, committing, then replacing the contents, committing again? |
Identifying renames in git is essentially a guess based on the similarity of the files before and after the rename, the actual names don't matter. According to the git docs the default similarity index is 50%, presumably GitHub uses that too. Joseph's suggestion is what I would normally recommend as it makes it slightly easier to see what happened in the history and since the rename is separated from the content change |
why do we care about the exact history? this app has only been run on 1 live beamline. I'll check the history thing on Tuesday if time allows |
This needs to be two commits:
|
45ba942
to
22bc7ab
Compare
22bc7ab
to
4f1f44c
Compare
that here is quite odd |
todo: need to remove the sphinx dependency and the CI jobs: moving the docs build config to reflect the one in the copier template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't these files require changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will review those all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea what is this about, :show-nested:, it couldn't be less informative
It appears to be embedding the rst inside the md rather than doing the equivalent md formatting :D |
I know that , it's an artifact from a fully rst times. But what sorcery did it do behind the scenes to dynamically import version like that? Do we want to support this in md? |
It's part of the configured tooling. I think it is correct for it to be there (it is available to call |
I am not sure that markdown supports dynamic imports into markdown like this |
I don't think that markdown calls this rightly, this is redundant information that could be deleted from |
closed by misclick |
following this comment to get it to work |
9ff8606
to
20f6911
Compare
correct some docs manually migrate some files missed one line correct the file formatting change to a python block add index got the docs to build locally without sphinx warnings
20f6911
to
f3ff32e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!