New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1615: Allow direct links to visit summary page #902

Open

ndg63276 wants to merge 1 commit into master from fix/LIMS-1615/allow-direct-link-to-summary-page

Collaborator

ndg63276 commented Feb 6, 2025

JIRA ticket: LIMS-1615

Summary:

Links to eg https://ispyb.diamond.ac.uk/dc/summary/visit/cm40608-1 don't work, as the proposal is not set.

Changes:

Set the proposal 'cookie' when navigating to the page. This is reverting commit 80ef089.

To test:

In a new browser tab for each, go to /dc/summary/visit/cm40608-1, /dc/apstatussummary/visit/cm40608-1, /dc/sc/visit/cm40608-1 and /dc/visit/cm40608-1 and check each one loads correctly, with the proposal set.
Try again, but log in as someone without permission to view that visit, check each page doesn't load


          LIMS-1615: Allow direct links to visit summary page

627ef73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet