Utilities Section remade #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Rushi98 I am not sure if many people use the landscape mode in our Application. We probably can make this landscape only app (Up for discussion). I'll fix UI problems you pointed out in 1st screenshot. |
|
It's not hard to support landscape grid layout. See how span count was calculated in the code you replaced. |
|
closing as out-of-date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #79
@Rushi98 Only three things are to be done:
A) I was not sure how to get menus from firebase here in Realm. So I've just created a viewholder and adapter class. You probably can add that logic. Won't take much time.
B) Currently only Taxi no. are visible and I was not able to add logic for scooty and car rental numbers. I really think the approach used in UtilitiesContactsActivity is very bad. Would prefer if it is done better.
C) As I didn't have data for menu currently. I have not implemented pinch to zoom feature in viewholder. Will do that in future commits.
Lets keep this PR active and develop on it. As I require collaborative help, I would appreciate if all the work is done in this PR.