feat(server): add volume support #641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add server messages and API to support setting client volume. Signed-off-by: Marc-André Lureau <[email protected]>
|
CI is broken for macOS WASM check. It appears the WebAssembly/wabt project deleted the macOS 14 artifacts for the release v1.0.33 we were relying on 🤷 |
|
Indeed, I cherry-picked it to be merged in a separate PR: #642 Auto-merge is enabled on this PR, so hopefully it should be merged as soon as you rebase it on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server messages and API to support setting client volume.