-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filtering with tags #23
base: main
Are you sure you want to change the base?
Conversation
@dvmhmdsd Thanks a lot for your contribution 🙌 In general, I like the approach; I'd only like to simplify it a bit. Here is my idea for it:
The code will be something like this:
|
Great idea |
@dvmhmdsd In general, yes, it will be just two categories. But I'd avoid relying on the name |
@aabouzaid I added the toggle button as checkbox for now (till we approve the idea) also i didn't give much attention to styling and focused on the idea itself The idea now is about wrapping the detailed devops section with
and the other sections with
and import the Also, I added the
|
@dvmhmdsd There is No need to make something super extendable now. So, I'd say let's stick with my first proposal. |
Hello @aabouzaid, I implemented your proposal which simplifies the logic, check and let me know. Also, if you want me to help in adding this feature to the rest of the documentation, let me know. |
@dvmhmdsd It looks great 🤩 Please go ahead and let's finalize it (style and so on), then I will review it. |
@aabouzaid Great 😃 |
As mentioned in issue #21 , this PR is only a POC for the idea.
The idea behind the PR:
TagsFilter
component which filters the content of the current page according to its class list.tags.json
file to add the supported tags across the website. e.g.devops
,fronend
, ...etc.tag-section
and also the tags supported. For example, when the user clicks on thefrontend
button and the section has classfronend
, then it will render only the sections that contains the classfrontend
.Please note that i didn't add any styling as this is only a POC till the idea is approved.
closes #21