Fixes for the SDKConfig Event; Featurevars is not required. #460
Conversation
- The default check should not expect an sdkconfig event - the delay is set to 2 seconds - when the flush is 500ms - Track needs to use arraycontaining - Fix go.mod version
Reviewer's Guide by SourceryThis pull request addresses several issues and improvements in the SDKConfig event handling and test cases. The changes include modifying the default check to not expect an SDKConfig event, updating the track tests to use arrayContaining, and fixing the go.mod version. Additionally, a new flag is introduced in the multithreading tests to skip the SDKConfig event. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JamieSinn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| '6386813a59f1b81cc9e6c68d': | ||
| '6386813a59f1b81cc9e6c693', | ||
| }, | ||
| }, {}]), |
There was a problem hiding this comment.
why are we not expecting featureVars to be set?
There was a problem hiding this comment.
Because the sdk config event is set under the aggregation user - we don't set featurevars on the aggregation user - as there's no features/variations to have been evaluated.
cc @ajwootto
Summary by Sourcery
This pull request addresses several issues related to the SDKConfig event handling and test configurations. It fixes the default check for sdkConfig events, updates the go.mod version, and refines test cases to improve event matching and handling.