Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for customData targeting filters with boolean, number or string values #440

Merged
merged 2 commits into from
Dec 13, 2024
Merged

fix: add support for customData targeting filters with boolean, number or string values #440

merged 2 commits into from
Dec 13, 2024

Conversation

kaushalkapasi
Copy link
Contributor

@kaushalkapasi kaushalkapasi commented Dec 13, 2024 •
edited
Loading

  • chore: add failing test for failing custom data targeting filter
  • feat: add support for boolean, number and string values on a Target Definition with "subType": "customData"

@kaushalkapasi kaushalkapasi force-pushed the fix-custom-data-filter-values-filter-validation branch from 22cf04f to 319e934 Compare December 13, 2024 17:06
@kaushalkapasi kaushalkapasi force-pushed the fix-custom-data-filter-values-filter-validation branch from 319e934 to 9ea3283 Compare December 13, 2024 19:00
@kaushalkapasi kaushalkapasi changed the title fix: add support for customData targeting filters with string values fix: add support for customData targeting filters with boolean, number or string values Dec 13, 2024
@kaushalkapasi kaushalkapasi requested a review from a team December 13, 2024 19:01
@kaushalkapasi kaushalkapasi marked this pull request as ready for review December 13, 2024 19:01
@kaushalkapasi kaushalkapasi merged commit 00f9f2d into main Dec 13, 2024
1 check passed
@kaushalkapasi kaushalkapasi deleted the fix-custom-data-filter-values-filter-validation branch December 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathannorris jonathannorris jonathannorris approved these changes

@suthar26 suthar26 suthar26 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalkapasi @jonathannorris @suthar26